Skip to content

evmmax: Implement modexp #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

evmmax: Implement modexp #1135

wants to merge 8 commits into from

Conversation

rodiazet
Copy link
Contributor

This PR implements expmod precompile using EVMMAX C++ API. The implementation restricts input sizes upper limit to 1024 bytes.

@rodiazet rodiazet force-pushed the modexp-evmmax-cpp branch 3 times, most recently from ad9dd5c to 94d4708 Compare February 18, 2025 12:14
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 98.23009% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.37%. Comparing base (44f2c85) to head (681d54a).

Files with missing lines Patch % Lines
lib/evmone_precompiles/modexp.cpp 98.31% 2 Missing ⚠️
test/precompiles_bench/precompiles_bench.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
- Coverage   94.47%   94.37%   -0.11%     
==========================================
  Files         168      170       +2     
  Lines       17984    17865     -119     
==========================================
- Hits        16991    16860     -131     
- Misses        993     1005      +12     
Flag Coverage Δ
eof_execution_spec_tests 21.05% <0.88%> (+0.13%) ⬆️
ethereum_tests 26.00% <54.22%> (-1.06%) ⬇️
ethereum_tests_silkpre 20.28% <65.35%> (+0.79%) ⬆️
execution_spec_tests 20.22% <39.55%> (-1.06%) ⬇️
unittests 91.50% <92.44%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/precompiles.cpp 99.03% <100.00%> (+0.04%) ⬆️
test/unittests/evmmax_modexp.cpp 100.00% <100.00%> (ø)
test/unittests/precompiles_expmod_test.cpp 100.00% <100.00%> (ø)
lib/evmone_precompiles/modexp.cpp 98.31% <98.31%> (ø)
test/precompiles_bench/precompiles_bench.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rodiazet rodiazet force-pushed the modexp-evmmax-cpp branch 6 times, most recently from fb40206 to 8ddff48 Compare February 19, 2025 14:53
@rodiazet rodiazet force-pushed the modexp-evmmax-cpp branch from 8ddff48 to e3c97f1 Compare March 13, 2025 15:06
@chfast chfast force-pushed the modexp-evmmax-cpp branch from e3c97f1 to 2172aa8 Compare March 13, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants